Testing refactors #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingar
pushed a commit
that referenced
this pull request
Dec 19, 2019
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
ingar
pushed a commit
that referenced
this pull request
Dec 19, 2019
* feat(retrievalmarket): extract from lotus Extract retrievalmarket from lotus, migrate to shared types, use cbor-gen-for, etc * Testing refactors (#21) * extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test Co-authored-by: Shannon Wells <shannonwells@users.noreply.github.com>
shannonwells
added a commit
that referenced
this pull request
Dec 20, 2019
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
shannonwells
added a commit
that referenced
this pull request
Dec 20, 2019
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
shannonwells
added a commit
that referenced
this pull request
Jan 2, 2020
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
shannonwells
added a commit
that referenced
this pull request
Jan 2, 2020
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
shannonwells
added a commit
that referenced
this pull request
Jan 8, 2020
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
shannonwells
added a commit
that referenced
this pull request
Jan 8, 2020
* extract mocknet setup from datatransfer testing, fold whitebox testing into graphsync_impl_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is some good but complicated libp2p mocknet setup in datatransfer/graphsync, which is almost entirely usable and needed for retrieval market testing.
Solution
extract mocknet setup from datatransfer testing, fold whitebox testin…g into graphsync_impl_test
Also: