Tentative acceptance protocol #244
Conversation
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 64.95% 64.80% -0.15%
==========================================
Files 39 40 +1
Lines 2285 2332 +47
==========================================
+ Hits 1484 1511 +27
- Misses 683 697 +14
- Partials 118 124 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Yay for the assert helper and this is mostly there.
However, as written, every deal with get data transfer events for every other deal (and non storage market data transfers)
You need to inspect the voucher in the data transfer state and verify it's a Storage Voucher, and then route it based on the proposal CID. I think this should be done not with a deal specific subscription but rather with a single subscription for all deals that just dispatches events outside the state handler. There's no need for a state handler unless events are triggered internally from the statemachine as a result of the previous transition.
you can look at providerutils/providerutils.go & DataTransferSubscriber for an example
ingar
force-pushed
the
feat/tentative-acceptance-protocol
branch
2 times, most recently
from
bf508c6
to
da31069
Compare
There was a problem hiding this comment.
Mostly minor cleanups but ones that should be done before merge:
- remove dead code
- fix use of provider event on client side
- fix set of starting states for ClientEventDataTransferFailed
- add missing test for StartDataTransfer returns err (cause would have caught provider event dispatched)
ingar
force-pushed
the
feat/tentative-acceptance-protocol
branch
from
77d65c9
to
82d04c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 65.04% 64.78% -0.25%
==========================================
Files 39 40 +1
Lines 2288 2331 +43
==========================================
+ Hits 1488 1510 +22
- Misses 683 696 +13
- Partials 117 125 +8
Continue to review full report at Codecov.
|
ingar
force-pushed
the
feat/tentative-acceptance-protocol
branch
from
af9f828
to
6b48786
Compare
State tests, rebase madness linting Fix erroneous state! remove debugging statement Remove dead function WIP PR feedback Fix client-side manual transfer transitions Remove dead code Refactor client state test fake environment initialization Refactor client state test Remove redundant Provider state Allow ClientEventDataTransferFailed event to transition from StorageDealTransferring!
- Remove unused event - Re-re-refactor client states test
add one state test and fix compile error
hannahhoward
force-pushed
the
feat/tentative-acceptance-protocol
branch
from
6b48786
to
04c42dc
Compare
Summary
Switch piece data transfer to a client push.
resolves #192