Tag deal connections to preserve them #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support using libp2p's connection manager tagging to preserve connections
hannahhoward
force-pushed
the
feat/protect-connections
branch
from
fee9504
to
80d4f53
Compare
ingar
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Don't drop open storage deal connections
Implementation
Libp2p's connection manager supports a tagging functionality which helps prevent connections from getting cleaned up when there are lots of them active.
This PR adds a method to do this to the storage deal stream, then pipes it through to the storage deal process so connections get tagged at the moment they become likely to stay open a long time and then untagged at close.
Unfortunately, libp2p's mock network has a connection manager that does nothing, so it's hard to test this at an actual integration level :(