Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes from filecoin integration work #253

Merged
merged 4 commits into from
May 14, 2020
Merged

Fixes from filecoin integration work #253

merged 4 commits into from
May 14, 2020

Conversation

hannahhoward
Copy link
Collaborator

@hannahhoward hannahhoward commented May 13, 2020 •
edited by ingar
Loading

So far:

  • fix an issue where we attempt to close a stream we never opened if funds are not ensured
  • update the universal request validator to support different stores for push + pull, make this the way of detecting if we accept pushes/pulls (if store = nil)

Need:
More fixes?
Tests for fix to close stream issue

hannahhoward and others added 4 commits May 12, 2020 21:25
@hannahhoward
fix(storagemarket): display failure correctly
f4c995c 
don't close a connection if it was never opened, so a failure to insure funds displays correctly
@hannahhoward
fix(storagemarket): validator configuration
c79f4a5 
allow setting acceptance of validation after initialization
@hannahhoward
feat(storagemarket): requestvalidator alterate stores
08f99ac
@ingar
Add test for closing streams when failing deals
d350895
@ingar ingar marked this pull request as ready for review May 13, 2020 22:27
@ingar ingar changed the title WIP Fixes from filecoin integration work Fixes from filecoin integration work May 13, 2020
@hannahhoward hannahhoward merged commit f769208 into master May 14, 2020
@ingar ingar deleted the feat/filecoin-integration-test branch June 24, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @ingar