Remove storedask from provider #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 64.06% 65.03% +0.98%
==========================================
Files 39 39
Lines 2245 2299 +54
==========================================
+ Hits 1438 1495 +57
+ Misses 690 687 -3
Partials 117 117
Continue to review full report at Codecov.
|
shannonwells
approved these changes
May 20, 2020
| @@ -220,6 +222,8 @@ func newStorageHarness(ctx context.Context, t *testing.T) *storageHarness { | |||
| ) | |||
| require.NoError(t, err) | |||
| dt2 := graphsyncimpl.NewGraphSyncDataTransfer(td.Host2, td.GraphSync2, td.DTStoredCounter2) | |||
| storedAsk, err := storedask.NewStoredAsk(td.Ds2, datastore.NewKey("latest-ask"), providerNode, providerAddr) | |||
| assert.NoError(t, err) | |||
There was a problem hiding this comment.
It's a nitpick but I think this should be a require.NoError since the test doesn't make sense unless this succeeds.
Move stored ask out of provider so its setup and configured seperately. Also allow customizing the DS key
hannahhoward
force-pushed
the
feat/remove-stored-ask
branch
from
3906e9e
to
7d68bbc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Add one more element of datastore customization
Implementation