Restartable storage deals #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingar
force-pushed
the
feat/finality-states
branch
3 times, most recently
from
de24e05
to
2744c0d
Compare
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 65.29% 63.67% -1.61%
==========================================
Files 40 40
Lines 2359 2400 +41
==========================================
- Hits 1540 1528 -12
- Misses 695 749 +54
+ Partials 124 123 -1
Continue to review full report at Codecov.
|
hannahhoward
requested changes
Jun 12, 2020
WIP Remove test for ensuring that state entry fn gets executed. This is already tested in go-statemachine. WIP WIP2 # Conflicts: # storagemarket/impl/provider.go # storagemarket/integration_test.go
ingar
force-pushed
the
feat/finality-states
branch
from
3b22de6
to
2b448d8
Compare
hannahhoward
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use the finality states in to declare terminal states for client and provider deals. On starting up, send either a
ProviderEventRestartorClientEventRestartevent to each deal that isn't in a terminal state.Resolves #79, #78
Note
This does not make every deal restartable at any point. It just adds the plumbing so that the restart event is sent, and will work in some cases.
Before this is ready to merge
go.modto point to new go-statemachine