replace AddAsk with SetAsk, to convey intent #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of go-fil-markets allows a storage miner to have exactly one ask, but the interface (before this commit) allowed the StorageProvider to return multiple asks, and the name AddAsk implies an additive operation that was, in fact, a replace of any existing ask.
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
+ Coverage 65.08% 65.16% +0.09%
==========================================
Files 40 40
Lines 2362 2359 -3
==========================================
Hits 1537 1537
+ Misses 700 697 -3
Partials 125 125
Continue to review full report at Codecov.
|
hannahhoward
approved these changes
Jun 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why does this PR exist?
Searching for a
DeleteAskoperation caused me to go down the rabbit hole of trying to figure out how asks added with theAddAskmethod could be replaced with a new ask (when the miner changed their minimum piece size, for instance).As it turns out, the current implementation of go-fil-markets allows a storage miner to have exactly one ask, manipulated through the misleadingly-named
AddAskmethod.What's in this PR?
This PR replaces the
AddAskmethod with aSetAskmethod, and replacesListAskswithGetAsk.Alternative approaches
If a
SignedStorageAskhad an identity (I don't see that it does right now), we could preserve theAddAskandListAskssignatures. We'd need to add aDeleteAskmethod, though.