Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

both StoredAsk and storage Provider are scoped to a single miner #276

Merged
merged 1 commit into from
Jun 15, 2020
Merged

both StoredAsk and storage Provider are scoped to a single miner #276

merged 1 commit into from
Jun 15, 2020

Conversation

laser
Copy link
Contributor

@laser laser commented Jun 15, 2020

Why does this PR exist?

Passing a miner address to the getter doesn't make much sense, since the object itself is scoped to a single miner.

@laser laser requested review from ingar and hannahhoward June 15, 2020 20:20
@codecov-commenter
Copy link

Codecov Report

Merging #276 into master will decrease coverage by 0.16%.
The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
- Coverage   63.75%   63.60%   -0.15%     
==========================================
  Files          40       40              
  Lines        2416     2417       +1     
==========================================
- Hits         1540     1537       -3     
- Misses        752      756       +4     
  Partials      124      124              
Impacted Files Coverage Δ
storagemarket/impl/provider.go 4.93% <0.00%> (-0.09%) ⬇️
storagemarket/types.go 33.34% <ø> (ø)
storagemarket/impl/storedask/storedask.go 80.00% <100.00%> (-0.51%) ⬇️
retrievalmarket/discovery/discovery.go 50.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8c329c...812d1db. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this. I think the though was future versions might support multiple addresses? I'm not exactly sure why this would be but who knows.

@hannahhoward hannahhoward merged commit 7d94d34 into filecoin-project:master Jun 15, 2020
@laser laser deleted the feat/remove-unused-address-parameter branch June 15, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants