Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip flaky test #30

Merged
merged 1 commit into from
Jan 9, 2020
Merged

skip flaky test #30

merged 1 commit into from
Jan 9, 2020

Conversation

shannonwells
Copy link
Contributor

Problem

This test is flaky; it passed a lot in the PR branch and flakes now that it's in master. This obviously causes problems for others.

Solution

Skip it while I work on it in a branch.

@codecov-io
Copy link

Codecov Report

Merging #30 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
- Coverage   14.97%   14.8%   -0.18%     
=========================================
  Files          26      26              
  Lines        1756    1756              
=========================================
- Hits          263     260       -3     
- Misses       1445    1447       +2     
- Partials       48      49       +1
Impacted Files Coverage Δ
retrievalmarket/network/query_stream.go 66.66% <0%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aa664e...d9f2efe. Read the comment docs.

Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shannonwells shannonwells merged commit d14f645 into master Jan 9, 2020
@shannonwells shannonwells deleted the bugs/disable-flaky-test branch January 9, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants