-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast retrieval support #305
Conversation
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
==========================================
- Coverage 63.32% 63.31% -0.01%
==========================================
Files 41 41
Lines 2538 2545 +7
==========================================
+ Hits 1607 1611 +4
- Misses 810 813 +3
Partials 121 121
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a component of the ticket:
Augment StorageProviderNode's OnDealComplete to take fast retrieval boolean
Ideally integration test should verify this bool matches when OnDealComplete is called on the testnode
Otherwise LGTM |
Note about changing the |
38d6037
to
120a966
Compare
Summary
Send the fast retrieval flag along with the proposal and track it in the
ClientDeal
andMinerDeal
. Also return this flag in the deal status query.Resolves #285