Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/make streams context aware #308

Merged
merged 3 commits into from
Jul 2, 2020
Merged

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Jul 1, 2020

Summary

Make the storage network New*Stream calls context-aware, and remove the context.Background() usage.

Resolves #292

@hannahhoward hannahhoward force-pushed the fix/make-streams-context-aware branch from f6be2d4 to e5ad802 Compare July 2, 2020 14:37
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #308 into master will increase coverage by 0.10%.
The diff coverage is 63.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   63.64%   63.74%   +0.10%     
==========================================
  Files          41       41              
  Lines        2582     2578       -4     
==========================================
  Hits         1643     1643              
+ Misses        818      814       -4     
  Partials      121      121              
Impacted Files Coverage Δ
storagemarket/impl/client.go 3.20% <0.00%> (ø)
storagemarket/impl/clientstates/client_states.go 90.00% <100.00%> (ø)
storagemarket/network/libp2p_impl.go 77.97% <100.00%> (ø)
storagemarket/types.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f33b442...e5ad802. Read the comment docs.

@hannahhoward hannahhoward merged commit 3d74eec into master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storagemarket: GetAsk isn't fully context-aware
3 participants