Run deal restarts in go routine #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
force-pushed
the
fix/restart-deals-error
branch
from
a5c9555
to
90b59ce
Compare
Deal restarts make take a while particularly if there are connection timeouts. There's no reason to run them synchronously in node initialization
hannahhoward
force-pushed
the
fix/restart-deals-error
branch
from
90b59ce
to
21be96a
Compare
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 63.65% 63.41% -0.24%
==========================================
Files 41 41
Lines 2569 2574 +5
==========================================
- Hits 1635 1632 -3
- Misses 813 820 +7
- Partials 121 122 +1
Continue to review full report at Codecov.
|
arajasek
approved these changes
Jul 2, 2020
|
@arajasek I think I'm gonna create a meta issue in markets that's like "deal reliability tracking" cause there are several things we may want to do. Note the current version of markets does not attempt to reopen connections btw cause the newest protocol has no long running libp2p connections for deals. |
hannahhoward
added a commit
that referenced
this pull request
Jul 2, 2020
Deal restarts make take a while particularly if there are connection timeouts. There's no reason to run them synchronously in node initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Deal restarts make take a while particularly if there are connection timeouts. There's no reason to
run them synchronously in node initialization, and we definitely should not fail node startup if there are errors.
Implementation
Run restart deals in a go routine, simply log any errors