Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locks protecting retrieval market maps #311

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 2, 2020

Closes #301
But see also #310, stuff never gets removed from these maps.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2020

Codecov Report

Merging #311 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   63.52%   63.63%   +0.12%     
==========================================
  Files          41       41              
  Lines        2582     2590       +8     
==========================================
+ Hits         1640     1648       +8     
  Misses        820      820              
  Partials      122      122              
Impacted Files Coverage Δ
retrievalmarket/impl/provider.go 70.32% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d74eec...f7d061b. Read the comment docs.

@hannahhoward
Copy link
Collaborator

Hi @vyzo!

Happy to merge this but FYI, the reason I didn't address 301 earlier is that we're about to merge some seperate big changes to retrieval which should obviate this issue. SO I would hold on 310

@vyzo
Copy link
Contributor Author

vyzo commented Jul 2, 2020

fair enough, let's merge it to avoid panics in our tests and we will retest with the big bawl of changes!

@hannahhoward hannahhoward merged commit 2a0c06a into master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic: newProviderDeal concurrent writes to map without synchronisation
3 participants