Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PieceCid to RetrievalPeer #312

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Jul 2, 2020

Summary

Add PieceCID *cid.Cid to RetrievalPeer so that callers can choose peers appropriately.

  • exercise local peer resolver in integration test
  • use cbor-gen for RetrievalPeer

Resolves #300

@ingar ingar force-pushed the feat/track-piece-cid-with-retrieval-peers branch from 812f240 to c725016 Compare July 2, 2020 21:37
@codecov-commenter
Copy link

Codecov Report

Merging #312 into master will decrease coverage by 0.42%.
The diff coverage is 70.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   63.75%   63.34%   -0.41%     
==========================================
  Files          41       41              
  Lines        2590     2561      -29     
==========================================
- Hits         1651     1622      -29     
- Misses        818      819       +1     
+ Partials      121      120       -1     
Impacted Files Coverage Δ
retrievalmarket/types.go 44.12% <ø> (ø)
storagemarket/impl/client.go 3.19% <0.00%> (-0.01%) ⬇️
retrievalmarket/discovery/local.go 61.91% <85.72%> (+0.93%) ⬆️
retrievalmarket/impl/blockio/traverser.go 68.89% <0.00%> (-3.33%) ⬇️
filestore/filestore.go 85.72% <0.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca8089...c725016. Read the comment docs.

@ingar ingar requested a review from hannahhoward July 2, 2020 21:43
- exercise local peer resolver in integration test
- use cbor-gen for RetrievalPeer
@hannahhoward hannahhoward force-pushed the feat/track-piece-cid-with-retrieval-peers branch from c725016 to dbc30f5 Compare July 7, 2020 19:53
@hannahhoward hannahhoward merged commit bc845dc into master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FindProviders & PeerResolver should return PieceCIDs
3 participants