Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add locks around client deals in retrieval market #315

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Jul 6, 2020

Closes #314

@vyzo vyzo requested a review from hannahhoward July 6, 2020 05:33
@codecov-commenter
Copy link

Codecov Report

Merging #315 into master will decrease coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   63.75%   63.34%   -0.40%     
==========================================
  Files          41       41              
  Lines        2590     2545      -45     
==========================================
- Hits         1651     1612      -39     
+ Misses        818      815       -3     
+ Partials      121      118       -3     
Impacted Files Coverage Δ
retrievalmarket/impl/client.go 67.34% <100.00%> (+1.85%) ⬆️
retrievalmarket/impl/blockio/traverser.go 68.89% <0.00%> (-3.33%) ⬇️
piecestore/piecestore.go 80.00% <0.00%> (-2.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca8089...8d89d41. Read the comment docs.

@vyzo
Copy link
Contributor Author

vyzo commented Jul 7, 2020

ping @hannahhoward -- let's get this merged.

@hannahhoward
Copy link
Collaborator

@vyzo sorry I thought I had merged this but I guess maybe I messed up? Anyway, doing now.

@hannahhoward hannahhoward merged commit a3dea6e into master Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in go-fil-markets/retrievalmarket/impl.(*client).Retrieve: concurrent map writes
3 participants