Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly add multiaddrs to avoid dialing issues #356

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

Handle MultiAddrs properly in storage market, retrieval market to avoid dialing issues

Implementation

  • Restore calling GetMinerInfo on the storage side when proposing and resuming deals
  • Up the timeout on adding multiaddrs
  • Add peerstore adding functionality to retrieval market network
  • Add a function on the RetrievalClientNode to get known addresses for a retrieval peer
  • Convert Retrieve function to take a RetrievalPeer
  • Add multiaddrs on both RetrievalQuery and Retrieve

Add multiaddrs properly in storage market, retrieval market
@hannahhoward hannahhoward requested a review from ingar August 5, 2020 22:18
Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't check all places that a peer is used. After the TTL expires the multiaddr gets added again?

@hannahhoward
Copy link
Collaborator Author

@ingar the assumption is with 8 HR TTL that should be enough to complete the current deal and every new deal/queery will readd the values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants