Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collateral from ProposeStorageDealParams #371

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

arajasek
Copy link
Collaborator

If the ProviderCollateral value is provided in the ProposeStorageDealParams, we should use it (if not, estimate it using `DealProviderCollateralBounds as before).

@arajasek arajasek self-assigned this Aug 14, 2020
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #371 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
- Coverage   61.83%   61.78%   -0.04%     
==========================================
  Files          41       41              
  Lines        2855     2857       +2     
==========================================
  Hits         1765     1765              
- Misses        939      941       +2     
  Partials      151      151              
Impacted Files Coverage Δ
storagemarket/impl/client.go 2.73% <0.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e15fa9...f9d090a. Read the comment docs.

@arajasek arajasek merged commit 7be996e into master Aug 14, 2020
@arajasek arajasek deleted the asr/provider-collateral branch September 7, 2020 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants