-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restart issue with deal transferring #381
Conversation
@hannahhoward Let me know if we need to test the restarts after more events. |
@aarshkshah1992 I would check ClientEventDealPublished and ClientEventDealActivated as well, though you can do so in a seperate ticket. That will also probably require making sure the node methods to not return immediately, as I imagine the final states are moved through in quick sucession during test (in a real environment, it's not quick) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run make prepare-pr
before merging to pass the docs-check
@aarshkshah1992 also TestMakeDealNonBlocking being flaky is a known issue -- if you want to look at that in a seperate ticket you're welcome to. |
98a6942
to
c3f88aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
- Coverage 61.47% 61.32% -0.15%
==========================================
Files 42 43 +1
Lines 2873 2882 +9
==========================================
+ Hits 1766 1767 +1
- Misses 956 964 +8
Partials 151 151
Continue to review full report at Codecov.
|
Created issue to track the remaining tests: |
Closes #378 .