-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry with exponential backoff for stream opening #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Yes, let's do this for retrieval as well.
make sure to fix lint errors before merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aarshkshah1992 -- I'm getting a freeze in the tests when I rebased on master after merging your other PR (the restart testing). Can you rebase on master and investigate?
@hannahhoward On it. |
f36f2ed
to
da08bc4
Compare
|
@aarshkshah1992 this great but it looks like you still have lint and test failures. At least one of the test failures looks non-flaky and needs a change. (TestProviderStop) |
da08bc4
to
8e44630
Compare
@hannahhoward Fixed the linting issue and test. Please take a look. The other failures are flakies for which I've created an issue. |
Closes filecoin-project/lotus#3416.
@hannahhoward Should we do this for the retrieval market as well ?