Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared types for exitcode and crypto #395

Merged
merged 5 commits into from
Sep 7, 2020

Conversation

ZenGround0
Copy link
Contributor

Pull actors exitcode and crypto types to shared stable types in go-state-types

@codecov-commenter
Copy link

Codecov Report

Merging #395 into master will increase coverage by 0.09%.
The diff coverage is 65.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   61.89%   61.97%   +0.09%     
==========================================
  Files          43       43              
  Lines        2925     3008      +83     
==========================================
+ Hits         1810     1864      +54     
- Misses        964      987      +23     
- Partials      151      157       +6     
Impacted Files Coverage Δ
retrievalmarket/impl/provider_environments.go 71.43% <ø> (ø)
...etrievalmarket/impl/providerstates/provider_fsm.go 8.83% <0.00%> (-1.17%) ⬇️
...market/impl/requestvalidation/requestvalidation.go 86.67% <ø> (ø)
...rievalmarket/impl/requestvalidation/revalidator.go 80.80% <ø> (ø)
retrievalmarket/types.go 42.38% <0.00%> (-4.79%) ⬇️
storagemarket/impl/client.go 2.89% <ø> (ø)
storagemarket/impl/clientstates/client_fsm.go 100.00% <ø> (ø)
storagemarket/impl/clientstates/client_states.go 89.37% <ø> (ø)
storagemarket/impl/funds/funds.go 77.50% <ø> (ø)
storagemarket/impl/provider.go 3.00% <ø> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dafdc47...afe9cdf. Read the comment docs.

@arajasek arajasek merged commit 9d489e1 into master Sep 7, 2020
arajasek pushed a commit that referenced this pull request Sep 7, 2020
* Use shared types for exitcode and crypto

* Fix imports

* Fix more imports

* Fix more imports again

* Fix more imports again v2 4 real

Co-authored-by: ZenGround0 <ZenGround0@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants