Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase retry timeout #402

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Increase retry timeout #402

merged 1 commit into from
Sep 14, 2020

Conversation

aarshkshah1992
Copy link
Collaborator

Increase retry timeout for connection attempts

hannahhoward
hannahhoward approved these changes Sep 14, 2020
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM by me

We are probably gonna have some tests run very long now so we'll need to figure that out eventually

@aarshkshah1992 aarshkshah1992 merged commit 1dfde6d into master Sep 14, 2020
@aarshkshah1992
Copy link
Collaborator Author

@hannahhoward

Yup, looks like TestProviderStop is already timing out. Can we go ahead and disable it ?

@aarshkshah1992 aarshkshah1992 deleted the feat/retry-timeout branch September 14, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aarshkshah1992 @hannahhoward