Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Retry Parameters (to speedup tests) #403

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

hannahhoward
Copy link
Collaborator

Goals

  • Remove need to for further PRs to change network retry parameters by making them a configuration option
  • Make tests run quickly again

Implementation

  • add the var args config option pattern to the Libp2p impls for storage and retrieval market networks
  • add an options to change all the retry parameters
  • set parameters to avoid retries in relevant tests

add config options to shorten or configure retry times
@codecov-commenter
Copy link

Codecov Report

Merging #403 into master will increase coverage by 0.21%.
The diff coverage is 90.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   61.97%   62.18%   +0.21%     
==========================================
  Files          43       43              
  Lines        3008     3027      +19     
==========================================
+ Hits         1864     1882      +18     
- Misses        987      989       +2     
+ Partials      157      156       -1     
Impacted Files Coverage Δ
storagemarket/impl/client.go 2.89% <0.00%> (ø)
storagemarket/impl/provider.go 3.00% <0.00%> (ø)
storagemarket/impl/clientutils/clientutils.go 78.27% <75.00%> (-1.04%) ⬇️
retrievalmarket/network/libp2p_impl.go 82.46% <100.00%> (+0.24%) ⬆️
storagemarket/impl/clientstates/client_states.go 89.37% <100.00%> (ø)
storagemarket/impl/providerstates/provider_fsm.go 91.02% <100.00%> (+0.11%) ⬆️
...oragemarket/impl/providerstates/provider_states.go 84.72% <100.00%> (ø)
storagemarket/network/libp2p_impl.go 81.12% <100.00%> (+2.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b18286...5cbbbdf. Read the comment docs.

Copy link
Collaborator

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@hannahhoward hannahhoward merged commit 64f78f7 into master Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants