Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist retrieval ask on disk #410

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Sep 21, 2020

Summary

Create a retrievalmarket AskStore interface and implementation, which will persist the retrieval ask to disk so that the configuration will persist through restarts. This is modeled after the storagemarket's StoredAsk.

Resolves filecoin-project/lotus/issues/3907

@codecov-commenter
Copy link

Codecov Report

Merging #410 into master will decrease coverage by 0.03%.
The diff coverage is 69.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
- Coverage   61.23%   61.21%   -0.02%     
==========================================
  Files          43       44       +1     
  Lines        2672     2714      +42     
==========================================
+ Hits         1636     1661      +25     
- Misses        880      889       +9     
- Partials      156      164       +8     
Impacted Files Coverage Δ
retrievalmarket/impl/provider.go 71.30% <50.00%> (-4.80%) ⬇️
retrievalmarket/impl/askstore/askstore_impl.go 71.74% <71.74%> (ø)
storagemarket/impl/storedask/storedask.go 78.58% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb2cbf...935085e. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit c99bb3c into master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retrieval Ask should be persisted
3 participants