Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storagemarket/client: close channel on ListProviders return #42

Merged
merged 1 commit into from
Jan 14, 2020
Merged

storagemarket/client: close channel on ListProviders return #42

merged 1 commit into from
Jan 14, 2020

Conversation

jsign
Copy link
Contributor

@jsign jsign commented Jan 14, 2020

Found while reading code. Mostly missed since chan isn't used yet.

@jsign
storagemarket: close channel on return
4a873ab 
Signed-off-by: jsign <jsign.uy@gmail.com>
@jsign jsign changed the title storagemarket: close channel on return storagemarket/client: close channel on ListProviders return Jan 14, 2020
ingar
ingar approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@ingar ingar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hannahhoward hannahhoward merged commit 83a7ae2 into filecoin-project:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingar ingar ingar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsign @ingar @hannahhoward