Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle re-sent deal proposals #423

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

ingar
Copy link
Contributor

@ingar ingar commented Oct 2, 2020

Problem

There is an edge case in the deal flow where a client sends the deal proposal and shuts down for some reason. When the client restarts, it resends the deal proposal, but the provider has already started tracking the deal, and rejects the proposal.

Solution

There is no problem with re-sending the deal response, and not changing anything in the provider state. This will allow the deal to continue on the client's state machine.

Resolves part of filecoin-project/lotus#3966

@codecov-commenter
Copy link

Codecov Report

Merging #423 into master will increase coverage by 0.31%.
The diff coverage is 63.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   66.02%   66.33%   +0.31%     
==========================================
  Files          48       48              
  Lines        3178     3189      +11     
==========================================
+ Hits         2098     2115      +17     
+ Misses        846      830      -16     
- Partials      234      244      +10     
Impacted Files Coverage Δ
storagemarket/impl/provider.go 28.90% <63.64%> (+5.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7227b2...68d676e. Read the comment docs.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahhoward hannahhoward merged commit 7911c1c into master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants