Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass PublishCID #441

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

hannahhoward
Copy link
Collaborator

Goals

Add PublishCID parameter to OnDealSectorCommitted so that function can account for DealID changes

Implementation

Change method signature, add params

@codecov-io
Copy link

codecov-io commented Nov 9, 2020

Codecov Report

Merging #441 (eb11d5e) into master (e384b80) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   65.59%   65.59%           
=======================================
  Files          48       48           
  Lines        3283     3283           
=======================================
  Hits         2153     2153           
  Misses        878      878           
  Partials      252      252           
Impacted Files Coverage Δ
storagemarket/impl/clientstates/client_states.go 85.72% <100.00%> (ø)
...oragemarket/impl/providerstates/provider_states.go 82.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 600a767...eb11d5e. Read the comment docs.

add PublishCID parameter to OnDealSectorCommitted
Pass the deal proposal CID to OnDealSectorCommitted
switch from proposal CID to deal proposal for OnDealSectorCommitted
@hannahhoward hannahhoward force-pushed the feat/pass-publish-cid-for-sector-commit branch from 58f0437 to eb11d5e Compare November 10, 2020 03:42
@hannahhoward hannahhoward merged commit d8b8581 into master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants