Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate new FundManager #445

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Integrate new FundManager #445

merged 3 commits into from
Nov 11, 2020

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Nov 10, 2020 •
edited by hannahhoward
Loading

Goals

Integrate with the new Fund Manager in Lotus

Implementation

  • Remove the internal fund manager in go-fil-markets
  • convert EnsureFunds to ReserveFunds that both reserves funds and insures they are available in the SMA as needed
  • add ReleaseFunds method
  • change names of states and events (don't worry, the indexing will not change, they just have new names)
  • while the PR may appear long, the only substantive changes are in clientstates.go & providerstates.go -- everything else is just renaming.

This was referenced Nov 10, 2020
Merged
Merged
@hannahhoward
feat(storagemarket): new fund manager node interface
9726b0d 
remove internal fund manager. switch to using release/reserve on node. Correct language around
ensure/reserve
@hannahhoward hannahhoward marked this pull request as ready for review November 11, 2020 01:01
@hannahhoward hannahhoward force-pushed the refactor/fund-manager branch 2 times, most recently from efafec6 to 09a4ad7 Compare November 11, 2020 02:06
arajasek
arajasek approved these changes Nov 11, 2020
View reviewed changes
Copy link
Collaborator

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me

dirkmc
dirkmc commented Nov 11, 2020
View reviewed changes
Copy link
Contributor Author

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@arajasek arajasek merged commit f296b89 into master Nov 11, 2020
@dirkmc dirkmc deleted the refactor/fund-manager branch November 11, 2020 08:13
This was referenced Nov 11, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward left review comments

@arajasek arajasek arajasek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirkmc @hannahhoward @arajasek