Remove temp files

[hannahhoward]

Do not generate temporary files for pieces in normal workflow

[hannahhoward]

I believe the test failure on ClientDealAccepted is real, most likely due to some reduced resumability for the code in the HandoffDeal function. I suspect that the problem has to do deleting the blockstore twice. (the blockstore now needs to hang around through on deal handed off? Not sure)

[dirkmc]

@hannahhoward I moved deletion of the deal store to CleanupDeal() (where the piece path and metadata path are cleaned up) and this fixed the test failures in TestRestartClient/ClientEventDealAccepted.
I believe it makes sense for deal store deletion to happen there because the client may want to retrieve the data before it's been sealed, right?

I'm wondering if we should also clean up temporary files / datastore storage if there's any failure during the deal?

Edit: We do already clean up temp files / datastore storage if there's a failure

[codecov-io]

Codecov Report

Merging #449 (47cd348) into master (8203454) will increase coverage by 0.04%.
The diff coverage is 80.89%.

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
+ Coverage   65.16%   65.20%   +0.04%     
==========================================
  Files          47       47              
  Lines        3140     3229      +89     
==========================================
+ Hits         2046     2105      +59     
- Misses        861      880      +19     
- Partials      233      244      +11     

Impacted Files	Coverage Δ
storagemarket/impl/provider_environments.go	2.13% <0.00%> (-0.04%)	⬇️
pieceio/pieceio.go	68.30% <83.34%> (-0.45%)	⬇️
...oragemarket/impl/providerstates/provider_states.go	83.53% <85.37%> (-0.35%)	⬇️
storagemarket/impl/provider.go	27.93% <100.00%> (ø)
storagemarket/impl/providerstates/provider_fsm.go	71.82% <100.00%> (-2.94%)	⬇️
storagemarket/impl/providerutils/providerutils.go	95.13% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8203454...47cd348. Read the comment docs.

[dirkmc]

LGTM 👍