-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StorageDealAwaitingPreCommit state #453
Conversation
08c7fef
to
f342fec
Compare
f342fec
to
6907f90
Compare
I am still very new to this code, but overall looks good to me! |
Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is actually important to move the new deal state to the bottom of the list -- otherwise you need to write a migration for deal states. It's no worries -- I'll do it for you and merge, just a heads up.
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
==========================================
+ Coverage 65.01% 65.45% +0.44%
==========================================
Files 46 46
Lines 3152 3192 +40
==========================================
+ Hits 2049 2089 +40
Misses 871 871
Partials 232 232
Continue to review full report at Codecov.
|
7c22330
to
c7fd401
Compare
Right, this was going to offset a lot of states, including |
Markets side of filecoin-project/lotus#4900