Normalize final states for cancelled retrieval deals #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for retrieval clients
ingar
force-pushed
the
feat/cancel-retrieval-deals-on-cancelled-transfer
branch
from
ee2bff5
to
2617dcc
Compare
Codecov Report
@@ Coverage Diff @@
## master #464 +/- ##
==========================================
+ Coverage 65.51% 65.58% +0.07%
==========================================
Files 46 46
Lines 3198 3198
==========================================
+ Hits 2095 2097 +2
+ Misses 877 875 -2
Partials 226 226
Continue to review full report at Codecov.
|
dirkmc
approved these changes
Dec 4, 2020
| DealStatusSendFunds | ||
|
|
||
| // DealStatusSendFundsLastPayment indicats the client is now going to send final funds because |
| fsm.Event(rm.ClientEventCancel).FromAny().To(rm.DealStatusCancelling).Action(func(deal *rm.ClientDealState) error { | ||
| deal.Message = "Retrieval Cancelled" | ||
| deal.Message = "Client cancelled retrieval" |
There was a problem hiding this comment.
I think that the provider can also cancel the deal - are we guaranteed to only get to this action if the client cancels?
There was a problem hiding this comment.
Yeah, when the provider cancels it comes from the data transfer event, translated into the ClientEventProviderCancelled event.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A retrieval deal can be cancelled by either the client or provider. The deals, when cancelled, were either going to error states or cancelled states depending on if you were a client or provider. In addition, this state transition was done without cleaning up the tracking, closing channels, etc.
Solution
Make all deals that are "cancelled" by either the client or provider have a final state of
DealStatusCancelled, with the reason for the cancel stored in themsgfield.