handle retrieval deals with zero price per byte #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent a crash when retrieval deal price per byte is zero.
Addresses filecoin-project/lotus#5140 filecoin-project/lotus#5409 (comment)
Improvements
Currently the flow is
This PR handles the case that the retrieval deal price per byte is zero:
When the data has completed transferring
Out of scope
In a future PR we should make more comprehensive changes for free retrievals: