Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cbor-gen to ingore unknown map fields #492

Merged
merged 2 commits into from
Feb 19, 2021
Merged

Update cbor-gen to ingore unknown map fields #492

merged 2 commits into from
Feb 19, 2021

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Feb 19, 2021

@magik6k magik6k requested a review from dirkmc February 19, 2021 11:56
@codecov-io
Copy link

Codecov Report

Merging #492 (d73d1a9) into master (0d6c6e4) will increase coverage by 0.11%.
The diff coverage is 87.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   65.05%   65.16%   +0.11%     
==========================================
  Files          50       50              
  Lines        3256     3266      +10     
==========================================
+ Hits         2118     2128      +10     
- Misses        911      912       +1     
+ Partials      227      226       -1
Impacted Files Coverage Δ
...oragemarket/impl/providerstates/provider_states.go 85.67% <87.10%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32f7f2e...d73d1a9. Read the comment docs.

dirkmc
dirkmc approved these changes Feb 19, 2021
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dirkmc dirkmc merged commit 1002d0c into master Feb 19, 2021
@dirkmc dirkmc deleted the deps/soft-map-cborgen branch February 19, 2021 13:17
@magik6k magik6k mentioned this pull request Feb 19, 2021
Merged
3 tasks
@dirkmc dirkmc mentioned this pull request Feb 22, 2021
Merged
bibibong pushed a commit to EpiK-Protocol/go-epik-markets that referenced this pull request Feb 24, 2021
@magik6k @bibibong
Update cbor-gen to ingore unknown map fields (filecoin-project#492)
bec82e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magik6k @codecov-io @dirkmc