close the reader after unsealing into blockstore #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
fix/read-blockstore-close-rdr
branch
2 times, most recently
from
a5a085f
to
78b1e74
Compare
dirkmc
force-pushed
the
fix/read-blockstore-close-rdr
branch
from
78b1e74
to
b57e0ed
Compare
aarshkshah1992
approved these changes
Mar 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be an issue where the error message when unsealing fails is getting swallowed: filecoin-project/lotus#5829
To make sure any read errors are surfaced, this PR explicitly closes the reader after reading the the unsealed data into the blockstore and returns any error.