Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow anonymous submodule checkout #535

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Allow anonymous submodule checkout #535

merged 1 commit into from
Apr 7, 2021

Conversation

ribasushi
Copy link
Contributor

No description provided.

@ribasushi ribasushi requested a review from dirkmc April 7, 2021 11:00
@dirkmc
Copy link
Contributor

dirkmc commented Apr 7, 2021

LGTM but could you add a couple of lines explaining what use case we need this for?

@ribasushi
Copy link
Contributor Author

Errr... if you do:

git clone https://github.com/filecoin-project/go-fil-markets
cd go-fil-markets
make build

it will fail unless you are a part of the filecoin-project org and have your ssh-agent at the ready to checkout the needed submodules.

@dirkmc dirkmc merged commit be1da4a into master Apr 7, 2021
@dirkmc dirkmc deleted the chore/anonymous_submodule_path branch April 7, 2021 11:24
@dirkmc dirkmc mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ribasushi @dirkmc