-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix restarts during data transfer for a retrieval deal #540
Conversation
582d918
to
f696914
Compare
5812917
to
03977c6
Compare
03977c6
to
2929073
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments/questions.
…payment but hasnt reached payment interval
Codecov Report
@@ Coverage Diff @@
## master #540 +/- ##
==========================================
+ Coverage 65.54% 65.77% +0.23%
==========================================
Files 53 56 +3
Lines 3549 3634 +85
==========================================
+ Hits 2326 2390 +64
- Misses 990 1009 +19
- Partials 233 235 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dirkmc Have finished the review. Some questions/concerns.
Astounding work !
f044f4a
to
25f4f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment. LGTM.
Fixes #533
Supersedes #539
Depends on filecoin-project/go-data-transfer#197
TODO:
validatePull()