For retrievals don't round down payments to interval lower bound #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
changed the title
Codecov Report
@@ Coverage Diff @@
## master #549 +/- ##
=======================================
Coverage 65.77% 65.77%
=======================================
Files 56 56
Lines 3634 3634
=======================================
Hits 2390 2390
Misses 1009 1009
Partials 235 235
Continue to review full report at Codecov.
|
aarshkshah1992
requested review from
hannahhoward and
aarshkshah1992
and removed request for
hannahhoward
|
Merged as part of #550 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix filecoin-project/lotus#6297 (when bubbled up to lotus)
When sending a payment voucher, we were rounding down the amount to the lower bound of the payment interval, so that payment would always proceed in exact intervals.
This PR changes the behaviour not to round down: the client will send a voucher that pays for all data that has been received (which may be more than the lower bound of the payment interval)