-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Stop funcs to retrieval providers #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
+ Coverage 33.82% 34.12% +0.3%
=========================================
Files 36 36
Lines 2608 2615 +7
=========================================
+ Hits 882 892 +10
+ Misses 1590 1588 -2
+ Partials 136 135 -1
Continue to review full report at Codecov.
|
@shannonwells - Looks like a sane PR to me. |
…r, by request rename Run() in storage interface/impl to Start for symmetry
d7873d4
to
f5d0abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Why are we changing the context timeouts?
@shannonwells - PR is ready to move forward, modulo test failure |
Change summary
Effects:
if a Provider is still connected to the libp2p network and a request comes in, the response will be an error:
protocol mismatch in lazy handshake
.