Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Stop funcs to retrieval providers #56

Merged
merged 9 commits into from
Jan 24, 2020

Conversation

shannonwells
Copy link
Contributor

@shannonwells shannonwells commented Jan 23, 2020

Change summary

  • Add a Stop func to interface and implementation for retrieval provider

Effects:
if a Provider is still connected to the libp2p network and a request comes in, the response will be an error: protocol mismatch in lazy handshake.

@shannonwells shannonwells changed the title Add Stop funcs to retrieval providers [WIP] Add Stop funcs to retrieval providers Jan 23, 2020
@codecov-io
Copy link

codecov-io commented Jan 23, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.3%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #56     +/-   ##
=========================================
+ Coverage   33.82%   34.12%   +0.3%     
=========================================
  Files          36       36             
  Lines        2608     2615      +7     
=========================================
+ Hits          882      892     +10     
+ Misses       1590     1588      -2     
+ Partials      136      135      -1
Impacted Files Coverage Δ
retrievalmarket/network/libp2p_impl.go 74.36% <100%> (+12.6%) ⬆️
retrievalmarket/impl/provider.go 72.8% <100%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b528580...2795fee. Read the comment docs.

@laser
Copy link
Contributor

laser commented Jan 23, 2020

@shannonwells - Looks like a sane PR to me.

Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Why are we changing the context timeouts?

retrievalmarket/impl/integration_test.go Outdated Show resolved Hide resolved
@laser
Copy link
Contributor

laser commented Jan 24, 2020

@shannonwells - PR is ready to move forward, modulo test failure

@shannonwells shannonwells merged commit 1aa65e2 into master Jan 24, 2020
@shannonwells shannonwells deleted the feat/add-stop-methods branch January 24, 2020 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants