Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On overloaded CI 10 seconds just isn't enough #587

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

ribasushi
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #587 (de0fdde) into master (b9e514c) will decrease coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
- Coverage   66.77%   66.55%   -0.22%     
==========================================
  Files          56       56              
  Lines        4227     4223       -4     
==========================================
- Hits         2822     2810      -12     
- Misses       1155     1163       +8     
  Partials      250      250              
Impacted Files Coverage Δ
storagemarket/impl/provider.go 29.04% <0.00%> (ø)
storagemarket/impl/requestvalidation/common.go 85.19% <ø> (-1.91%) ⬇️
retrievalmarket/events.go 0.00% <0.00%> (-80.00%) ⬇️
retrievalmarket/dealstatus.go 0.00% <0.00%> (-80.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f15eef9...de0fdde. Read the comment docs.

@ribasushi ribasushi marked this pull request as ready for review July 23, 2021 22:21
@whyrusleeping whyrusleeping merged commit aa86bc2 into master Jul 23, 2021
@ribasushi ribasushi deleted the chore/fix_intermittent_ci_fail branch July 23, 2021 22:32
aarshkshah1992 pushed a commit that referenced this pull request Jul 26, 2021
* remove wrong peer check in push deal validation (#585)

* remove wrong peer check in push deal validation

* kill the pull side of peer id checking as well

* fixup comments

* Do not hex-encode CIDs in logs (#561)

* On overloaded CI 10 seconds just isn't enough (#587)

* support padding out smaller files (#536)

* support padding out smaller files

* Actually write out the padding - AP depends on it

Co-authored-by: Peter Rabbitson <ribasushi@protocol.ai>

Co-authored-by: Whyrusleeping <why@ipfs.io>
Co-authored-by: Raúl Kripalani <raul@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants