Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstrate test failure with go-data-transfer v1.7.8 #621

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hannahhoward
Copy link
Collaborator

#615 is failing CI to a test related to cancelling data transfers. The failure is regular and appears on a local test run.

However, this issue is triggered by changes in go-data-transfer 1.7.8, which changes something with the cancelling process (see filecoin-project/go-data-transfer#245).

This PR just demonstrates the failure occurs by updated to 1.7.8 and nothing else. (the tests pass on v1.7.7 FWIW)

Previously, go-fil-markets was on 1.7.6. The go-graphsync update PR was not triggering the issue until now because it wasn't rebased on go-data-transfer master.

I'm not sure the intent of the changes in 1.7.8 so I'm not sure the best way this test should be fixed.

@dirkmc
Copy link
Contributor

dirkmc commented Sep 1, 2021

Thanks Hannah! Fixed in #622
I also pushed a commit to this branch with the same fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants