Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize definition of a recursive non-matching selector #640

Merged
merged 2 commits into from
Oct 11, 2021

Conversation

ribasushi
Copy link
Contributor

In the spirit of filecoin-project/lotus#7467

It was confirmed that key order in this map is irrelevant, therefore this is a non-functional change.

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although it'd be great to ditch shared/selectors.go entirely, I think Lotus is the only (edit: obvious/known) consumer of it and it's now been switched

shared/selectors.go Outdated Show resolved Hide resolved
Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
@ribasushi ribasushi requested a review from dirkmc October 10, 2021 06:16
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks!

@dirkmc dirkmc merged commit ea97d4e into master Oct 11, 2021
@dirkmc dirkmc deleted the chore/normalize-selector-use branch October 11, 2021 13:14
@dirkmc dirkmc mentioned this pull request Oct 11, 2021
rvagg pushed a commit that referenced this pull request Oct 15, 2021
* Standardize definition of a recursive non-matching selector

In the spirit of filecoin-project/lotus#7467

* Proprly deprecate as understood by the golang toolchain

Co-authored-by: Daniel Martí <mvdan@mvdan.cc>

Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants