Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace SelectiveCar prepare+dump with write for CommP #646

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace SelectiveCar prepare+dump with write for CommP #646

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 21, 2021

No description provided.

hannahhoward
hannahhoward approved these changes Oct 21, 2021
View reviewed changes
Copy link
Collaborator

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We didn't have commP writer at the time, this should work.

@jennijuju jennijuju mentioned this pull request Oct 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannahhoward hannahhoward hannahhoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @hannahhoward