Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-car to v2.1.0 #650

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Update go-car to v2.1.0 #650

merged 4 commits into from
Dec 6, 2021

Conversation

magik6k
Copy link
Collaborator

@magik6k magik6k commented Dec 6, 2021

This PR updates go-car to v2.1.0, and fixes compat with the filestore car(ish) index in the least hacky way per Slack discussion.

@magik6k magik6k changed the title Deps/car v2.1.0 Update go-car to v2.1.0 Dec 6, 2021
@mvdan
Copy link
Contributor

mvdan commented Dec 6, 2021

In kvcarbs.go, perhaps clarify what lines you changed from upstream and how, and state what commit hash it came from. For example, perhaps comment out a few lines as necessary, or do an if false { ... }. That should make the changes clearer, and if the code needs to be updated to a newer go-car in the future, at least it's going to be possible without pulling you in.

@magik6k magik6k merged commit 95704c9 into master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants