Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for go-data-transfer v1.13.0 #663

Closed
wants to merge 4 commits into from

Conversation

hannahhoward
Copy link
Collaborator

Goals

Support for go-data-transfer v1.13.0 which accepts transfers of incomplete DAGs that are missing CIDs

Implementation

The intent is two fold:

  1. A Storage deal transfer that is missing CIDs should just succeed. If someone assembles a CAR that is missing CIDs, as long as it matches commP on the other side we should accept the deal. Note: the CAR tooling needs updates as well.
  2. A Retrieval deal on the client records when it is missing cids -- this can be presented to the user at the end of retrieval as needed.

For Discussion

The intent is for this to get into Lotus 1.15. However, I see all the reference provider work has been done, causing me to wonder if this needs a markets 1.14 backport.

@codecov-commenter
Copy link

Codecov Report

Merging #663 (0b44483) into master (0f90512) will increase coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 0b44483 differs from pull request most recent head 4c38621. Consider uploading reports for the commit 4c38621 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   58.84%   59.04%   +0.20%     
==========================================
  Files          64       64              
  Lines        5320     5326       +6     
==========================================
+ Hits         3130     3144      +14     
+ Misses       1854     1846       -8     
  Partials      336      336              
Impacted Files Coverage Δ
retrievalmarket/events.go 80.00% <ø> (+80.00%) ⬆️
retrievalmarket/types.go 58.03% <ø> (ø)
retrievalmarket/impl/clientstates/client_fsm.go 67.92% <100.00%> (+0.99%) ⬆️
retrievalmarket/impl/dtutils/dtutils.go 81.52% <100.00%> (+0.32%) ⬆️
storagemarket/impl/dtutils/dtutils.go 74.03% <100.00%> (ø)
retrievalmarket/dealstatus.go 80.00% <0.00%> (+80.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f90512...4c38621. Read the comment docs.

@dirkmc
Copy link
Contributor

dirkmc commented Jan 20, 2022

Superseded by #665

@dirkmc dirkmc closed this Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants