better answer message on ErrNotFound #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
nonsense/better-answer-message
branch
2 times, most recently
from
4e10927
to
d17325f
Compare
dirkmc
approved these changes
Mar 8, 2022
nonsense
force-pushed
the
nonsense/better-answer-message
branch
from
d17325f
to
5e7372b
Compare
nonsense
force-pushed
the
nonsense/better-answer-message
branch
from
5e7372b
to
7c3132e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
retrievalmarket.ErrNotFound,answer.Messageis "", which results in a rather obscure error message, namely:This PR is adding an
answer.Messageso that we get the following error message, and make it clear that the mapping between data cid and piece is missing: