Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP 0027 integration #694

Merged
merged 2 commits into from
Apr 11, 2022
Merged

FIP 0027 integration #694

merged 2 commits into from
Apr 11, 2022

Conversation

arajasek
Copy link
Collaborator

@arajasek arajasek commented Mar 12, 2022

Integrates a change to FIP-0027. o

@arajasek arajasek changed the title Integrate proposed change to make deal Label a Union DO NOT MERGE: Integrate proposed change to make deal Label a Union Mar 12, 2022
@ZenGround0 ZenGround0 marked this pull request as ready for review April 7, 2022 21:06
@ZenGround0 ZenGround0 requested a review from dirkmc April 7, 2022 21:06
@ZenGround0
Copy link
Contributor

@arajasek I can't tag you for it but need your review here

@ZenGround0 ZenGround0 changed the title DO NOT MERGE: Integrate proposed change to make deal Label a Union FIP 0027 integration Apr 7, 2022
@ZenGround0
Copy link
Contributor

TestRestartOnlyProviderDataTransfer appears to be flaky

@codecov-commenter
Copy link

Codecov Report

Merging #694 (954803e) into master (70dbd2f) will increase coverage by 0.15%.
The diff coverage is 55.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #694      +/-   ##
==========================================
+ Coverage   58.60%   58.74%   +0.15%     
==========================================
  Files          64       64              
  Lines        5362     5390      +28     
==========================================
+ Hits         3142     3166      +24     
+ Misses       1882     1880       -2     
- Partials      338      344       +6     
Impacted Files Coverage Δ
storagemarket/impl/client.go 21.38% <ø> (ø)
storagemarket/impl/provider_environments.go 9.35% <0.00%> (+0.18%) ⬆️
storagemarket/impl/providerutils/providerutils.go 94.29% <ø> (ø)
storagemarket/types.go 85.37% <ø> (ø)
...oragemarket/impl/providerstates/provider_states.go 84.35% <33.34%> (-0.63%) ⬇️
storagemarket/impl/clientutils/clientutils.go 40.55% <55.56%> (+1.84%) ⬆️
storagemarket/impl/provider.go 26.88% <63.34%> (+3.99%) ⬆️

@arajasek
Copy link
Collaborator Author

arajasek commented Apr 8, 2022

Approve to all of @ZenGround0's commits! If someone can review the first commit and green check this, we can merge!

Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this PR but I do have one non-blocking question.
There is a commented out test in storagemarket/impl/providerstates/provider_states_test.go.
Why is this test commented out? If it's no longer relevant let's remove it.

@ZenGround0
Copy link
Contributor

There is a commented out test in storagemarket/impl/providerstates/provider_states_test.go.
Why is this test commented out? If it's no longer relevant let's remove it.

Thanks, this test is made irrelevant by the new label type which forbids invalidly long labels at the type level. Removing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants