Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fire storage deal provider ready event after startup completes #708

Merged
merged 1 commit into from
May 9, 2022

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented May 9, 2022

Ensure that the "ready" event is only fired after the start() method returns

@codecov-commenter
Copy link

Codecov Report

Merging #708 (a9652b0) into master (70dbd2f) will increase coverage by 0.08%.
The diff coverage is 49.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   58.60%   58.67%   +0.08%     
==========================================
  Files          64       64              
  Lines        5362     5398      +36     
==========================================
+ Hits         3142     3167      +25     
- Misses       1882     1886       +4     
- Partials      338      345       +7     
Impacted Files Coverage Δ
storagemarket/impl/client.go 21.38% <ø> (ø)
storagemarket/impl/provider_environments.go 9.35% <0.00%> (+0.18%) ⬆️
storagemarket/impl/providerutils/providerutils.go 94.29% <ø> (ø)
storagemarket/types.go 85.37% <ø> (ø)
...oragemarket/impl/providerstates/provider_states.go 84.35% <33.34%> (-0.63%) ⬇️
storagemarket/impl/provider.go 26.63% <52.39%> (+3.74%) ⬆️
storagemarket/impl/clientutils/clientutils.go 40.55% <55.56%> (+1.84%) ⬆️

@dirkmc dirkmc merged commit a088d71 into master May 9, 2022
@dirkmc dirkmc deleted the fix/provider-ready branch May 9, 2022 11:14
@dirkmc dirkmc mentioned this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants