Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: store identity CIDs in CARs for online deals #749

Merged
merged 2 commits into from
Oct 14, 2022
Merged

fix: store identity CIDs in CARs for online deals #749

merged 2 commits into from
Oct 14, 2022

Commits on Oct 14, 2022

  1. fix: store identity CIDs in CARs for online deals 

    matches historical precedent, without doing this we get CommP failures where
deals are made with intermediate inline CIDs and the client stores them in
the CAR used to make CommP. car.SelectiveCar is the historical way of doing
this.

e.g. https://github.com/filecoin-project/lotus/blob/a843c52e38da13da489cbe6b290ea49b2660b3fb/node/impl/client/client.go#L1405-L1412

Ref: ipld/go-car#332
    @rvagg
    rvagg committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    edb77eb View commit details
    Browse the repository at this point in the history

  2. chore: update to go-car/v2@2.5.0, released with necessary changes

    @rvagg
    rvagg committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    ee565ed View commit details
    Browse the repository at this point in the history