Chore/use go libipni #789
Merged
Chore/use go libipni #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Items from ipni/index-provider and ipni/storetheindex have moved into ipni/go-libipni
rvagg
reviewed
Apr 3, 2023
There was a problem hiding this comment.
So, these look good to me, I love dependency upgrades, especially this lot!
But, the failing tests look sus and I don't know much about them to be able to make a judgement call on them. They're all TestBounceConnection* and are still failing after a re-run. I think this is on @dirkmc to make a call on.
|
Those tests are flaky - if they pass locally I think it's fine to merge this PR |
|
@dirkmc With the latest graphsync updates, these tests pass now. |
dirkmc
approved these changes
Apr 14, 2023
Merged
dirkmc
pushed a commit
to filecoin-project/boost-gfm
that referenced
this pull request
May 25, 2023
* Depend on go-libipni Items from ipni/index-provider and ipni/storetheindex have moved into ipni/go-libipni * Use go1.19.7 for circleci * require go1.19 * Add generated files * gofmt doc.go files * Use latest graphsync with shutdown fix
dirkmc
added a commit
to filecoin-project/boost-gfm
that referenced
this pull request
Jun 19, 2023
Chore/use go libipni (filecoin-project#789)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.