feat(shared): add shared tools and types #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingar
approved these changes
Dec 16, 2019
| @@ -26,6 +26,8 @@ const ( | |||
| ExtensionDataTransfer = graphsync.ExtensionName("fil/data-transfer") | |||
| ) | |||
|
|
|||
| //go:generate cbor-gen-for ExtensionDataTransferData | |||
There was a problem hiding this comment.
wait till it breaks though...
| @@ -18,7 +18,7 @@ func NewLocalFileStore(basedirectory string) (FileStore, error) { | |||
| break | |||
| } | |||
| } | |||
| base := basedirectory[0:i + 1] | |||
| base := basedirectory[0 : i+1] | |||
There was a problem hiding this comment.
There's like path.Clean, path.Join that can do some of the path manipulation in this file...
go.mod
Outdated
| golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898 | ||
| google.golang.org/appengine v1.5.0 |
hannahhoward
force-pushed
the
feat/infrastructure
branch
2 times, most recently
from
7001c47
to
cc56e38
Compare
- copy important types from lotus - copy over address, cborutil, and crypto library - switch to generating cbor through cbor-gen-for + go-generate - run go fmt (hadn't been run) - remove external depedencies on lotus
hannahhoward
force-pushed
the
feat/infrastructure
branch
from
cc56e38
to
7951303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Move a bunch of shared stuff over from lotus so we can work with things internally
Implementation
//go:generate cbor-gen-for ~structName~comment near the struct that needs cbor methods and then just rungo generate ./...