Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom transport mode #114

Merged
merged 3 commits into from
Jun 6, 2024
Merged

feat: Custom transport mode #114

merged 3 commits into from
Jun 6, 2024

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Jun 6, 2024

This PR:

  • Makes it possible to create a client with a callback allowing for use with custom transports
    • Curio needs this for doing RPC to a sub-process, I can see there being other neat uses for this too
  • Adds a method on the Server handler which makes it possible to feed raw rpc frames into it and get responses, skipping the http layer
  • Obviously adds a test
  • Adds some docs to the README, also documenting reverse calling which I've noticed had zero docs

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 61.11111% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@81c1e3f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage          ?   71.88%           
=========================================
  Files             ?       11           
  Lines             ?     1494           
  Branches          ?        0           
=========================================
  Hits              ?     1074           
  Misses            ?      323           
  Partials          ?       97           
Files Coverage Δ
server.go 76.38% <100.00%> (ø)
client.go 81.62% <58.82%> (ø)

@magik6k magik6k requested a review from snadrus June 6, 2024 11:39
@magik6k magik6k merged commit e75dcdc into master Jun 6, 2024
7 checks passed
@magik6k magik6k deleted the feat/custom-backend branch June 6, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants